refactor: use 'unique' instead of 'create_unique_index' for m2m field #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1903 will not alter performanceComparing Summary
|
henadzit
requested changes
Feb 28, 2025
waketzheng
changed the title
unique instead of 'create_unique_index' for m2m field
Pull Request Test Coverage Report for Build 13615519024Details
💛 - Coveralls |
waketzheng
changed the title
unique instead of 'create_unique_index' for m2m field
henadzit
reviewed
Mar 1, 2025
| # TODO: rename through to through_table | ||
| # TODO: add through to use a Model | ||
| super().__init__(field_type, **kwargs) | ||
| super().__init__(field_type, unique=unique, **kwargs) |
Contributor
There was a problem hiding this comment.
Why do you need to pass unique explicitly here?
Contributor
Author
There was a problem hiding this comment.
Because ManyToManyFieldInstance inherit from class Field, which receive the unique parameter.
henadzit
approved these changes
Mar 3, 2025
Contributor
henadzit
left a comment
henadzit
left a comment
There was a problem hiding this comment.
LGTM! Although we should also update CHANGELOG, however, we can do it when doing a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: tortoise/aerich#406